Open
Conversation
mdziarkach
reviewed
Oct 17, 2024
src/services/meteorService.js
Outdated
| }); | ||
|
|
||
| if (count) { | ||
| return { count: filteredData.length }; |
src/services/meteorService.js
Outdated
| const dangerousMeteors = filteredData.filter( | ||
| (meteor) => meteor.is_potentially_hazardous_asteroid | ||
| ); | ||
| return { wereDangerousMeteors: dangerousMeteors.length > 0 }; |
src/services/meteorService.js
Outdated
| throw new Exception(500, "Failed to fetch data from NASA API"); | ||
| } | ||
|
|
||
| const meteorsArray = meteorsData[startDate]; |
src/services/meteorService.js
Outdated
|
|
||
| const getMeteorsData = async ({ date, count, wereDangerousMeteors }) => { | ||
| const startDate = dateUtils.getStartDateOrDefault(date); | ||
| const endDate = dateUtils.getEndDateOrDefault(date, startDate); |
There was a problem hiding this comment.
date can be range of dates
I updated task description
src/utils/dateUtils.js
Outdated
| return startDate || new Date().toISOString().split('T')[0]; | ||
| } | ||
|
|
||
| exports.getEndDateOrDefault = function (endDate, startDate) { |
There was a problem hiding this comment.
be consistent please in export approach
mdziarkach
approved these changes
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.